lkml.org 
[lkml]   [2012]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/3] hid: Enable report fixup on rebind
On Mon, 30 Apr 2012, Henrik Rydberg wrote:

> > Regarding the code, could it be the time to fix naming of report
> > descriptor-handling functions to improve distinction from report-handling
> > ones? I'm attaching a patch applying on top of Henrik's changes which should
> > illustrate the proposal.
>
> The changes you propose force changes to out-of-tree-drivers, without
> any obvious benefit.

I agree that *_parse_rdesc() would be much better than *_parse_report()
(we have been having this slight misnomer in the HID code since ever).

I wouldn't care too much about out-of-tree drivers, they have to adapt
gradually to our random HID API changes anyway.

Thanks to both of you,

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2012-04-30 14:41    [W:0.749 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site