Messages in this thread | | | Date | Mon, 30 Apr 2012 11:17:49 +0200 | From | Andi Shyti <> | Subject | Re: [PATCH] MFD : add MAX77686 mfd driver |
| |
Hi,
> + mutex_lock(&max77686->iolock); > + ret = i2c_smbus_read_i2c_block_data(i2c, reg, count, buf); > + mutex_unlock(&max77686->iolock);
Is it relly necessay to lock whenever you read/write from/to the i2c bus? Considering also that these are exported function, someone else may lock here before, so we can have a double locking on the same mutex.
Andi
| |