Messages in this thread | | | Date | Tue, 3 Apr 2012 09:07:24 -0500 | From | Seth Forshee <> | Subject | Re: [PATCH v2] toshiba_acpi: Add support for transflective LCD |
| |
On Tue, Apr 03, 2012 at 10:57:28PM +0900, Akio Idehara wrote: > Hi, Seth. > > Thank you for reviewing my code again and again. > All your comments make sense. > I'll try to make the v3 patch.
Great!
I realized I also forgot to mention, it would be better to come up with a more descriptive name than tmp for the local variable you added to get_lcd() as well.
Thanks, Seth
| |