lkml.org 
[lkml]   [2012]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] xen/gntdev: do not set VM_PFNMAP
On Tue, Apr 03, 2012 at 12:25:02PM +0100, Stefano Stabellini wrote:
> Since when we are using the m2p_override it is not true anymore that the
^^^^ - get rid of that.
> mmap'ed area doesn't have corresponsing struct pages.

That reads to me as !!do struct page. Which comes out as:

"m2p_override_* API the mmap-ed are have corresponding struct pages' ?


>
> Removing the VM_PFNMAP flag makes get_user_pages work on the mmap'ed user vma.
> An example test case would be using a Xen userspace block backend
> (QDISK) on a file on NFS using O_DIRECT.
>
> The patch should be backported back to 2.6.38.

Add CC: stable@kernel.org then. But does this patch depend on other
patches?

>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> ---
> drivers/xen/gntdev.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 99d8151..1ffd03b 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -722,7 +722,7 @@ static int gntdev_mmap(struct file *flip, struct vm_area_struct *vma)
> vma->vm_flags |= VM_RESERVED|VM_DONTEXPAND;
>
> if (use_ptemod)
> - vma->vm_flags |= VM_DONTCOPY|VM_PFNMAP;
> + vma->vm_flags |= VM_DONTCOPY;
>
> vma->vm_private_data = map;
>
> --
> 1.7.2.5


\
 
 \ /
  Last update: 2012-04-03 15:27    [W:0.071 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site