Messages in this thread Patch in this message | | | From | H Hartley Sweeten <> | Subject | [PATCH] NFC: hci/core.c: local variables should not be exposed globally | Date | Thu, 26 Apr 2012 11:05:40 -0700 |
| |
The variable 'hci_nfc_ops' is only referenced in this file and should be marked static to prevent it from being exposed globally.
Quites the sparse warning:
warning: symbol 'hci_nfc_ops' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Lauro Ramos Venancio <lauro.venancio@openbossa.org> Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org> Cc: Samuel Ortiz <sameo@linux.intel.com> Cc: "David S. Miller" <davem@davemloft.net>
---
diff --git a/net/nfc/hci/core.c b/net/nfc/hci/core.c index 86fd00d..0ce5ee4 100644 --- a/net/nfc/hci/core.c +++ b/net/nfc/hci/core.c @@ -605,7 +605,7 @@ static int hci_data_exchange(struct nfc_dev *nfc_dev, u32 target_idx, return 0; } -struct nfc_ops hci_nfc_ops = { +static struct nfc_ops hci_nfc_ops = { .dev_up = hci_dev_up, .dev_down = hci_dev_down, .start_poll = hci_start_poll,
| |