[lkml]   [2012]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] leds: add new transient trigger for one shot timer activation
On Wed, 25 Apr 2012 11:42:38 -0600 Shuah Khan <> wrote:

> There was a suggestion to change units to seconds similar to "safe_delay_show"
> and "safe_delay_store" in drivers/md/md.c. safe_delay_show shows time in
> seconds, however safe_delay_store still takes the value in msecs. This
> sounded like an asymmetric interface.

I don't think you read the code properly. "strict_strtoul_scaled" takes
a number like "0.20" and scales it to an integer...
(though your decision not to take that approach may still be justified).

[unhandled content-type:application/pgp-signature]
 \ /
  Last update: 2012-04-26 08:05    [W:0.139 / U:2.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site