lkml.org 
[lkml]   [2012]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH RFC tip/core/rcu 5/6] rcu: Make __kfree_rcu() less dependent on compiler choices
    From
    Date
    On Mon, 2012-04-23 at 09:42 -0700, Paul E. McKenney wrote:
    > Currently, __kfree_rcu() is implemented as an inline function, and
    > contains a BUILD_BUG_ON() that malfunctions if __kfree_rcu() is compiled
    > as an out-of-line function. Unfortunately, there are compiler settings
    > (e.g., -O0) that can result in __kfree_rcu() being compiled out of line,
    > resulting in annoying build breakage. This commit therefore converts
    > both __kfree_rcu() and __is_kfree_rcu_offset() from inline functions to
    > macros to prevent such misbehavior on the part of the compiler.

    The kernel very explicitly doesn't support being compiled with -O0, so
    this is a non-issue, I think you can make it work if you add
    -finline-functions.

    I'd drop this, either make the entire kernel compile or don't bother.


    \
     
     \ /
      Last update: 2012-04-26 14:51    [W:0.032 / U:91.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site