lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] regulator: core: Keep boot_on regulators powered during init
On Tue, Apr 24, 2012 at 02:43:20PM +0200, Ulf Hansson wrote:

> So if grabbing a reference, there is no good point in the code were
> I can drop it. Moreover _every_ host driver needs to handle this. It
> will likely become a "hack" is my first impression.

If it's something that every host driver needs to do then just factor it
into the framework and we're done... The stuff you're trying to put in
the regulator API feels equally like it's a bodge and it seems to me
like we've just not thought of the best way for the MMC stack to figure
out and keep track of if it needs a regulator or not.

> >This just seems awfully fragile and very much dependant on things like
> >having the driver actually enabled to clean up later.

> Setting this constraint is not done be "default", it could be
> clearly be stated that the consumer must handle the enable/disable,
> otherwise the regulator will be left in the state it was when the
> kernel booted.

Right, but the whole point in having full constraints is to avoid that.
Users are supposed to set constraints to grant permissions for things,
not to work around internal problems in the rest of the stack. If I
could see a general use case for the feature... but I'm having trouble
doing that.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2012-04-25 10:05    [W:0.140 / U:12.628 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site