lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4/6] ext2: Remove i_mutex use from ext2_quota_write()
    Date
    We don't need i_mutex in ext2_quota_write() because writes to quota file
    are serialized by dqio_mutex anyway. Changes to quota files outside of quota
    code are forbidded and enforced by NOATIME and IMMUTABLE bits.

    Signed-off-by: Jan Kara <jack@suse.cz>
    ---
    fs/ext2/super.c | 6 +-----
    1 files changed, 1 insertions(+), 5 deletions(-)

    diff --git a/fs/ext2/super.c b/fs/ext2/super.c
    index e1025c7..1a6fb52 100644
    --- a/fs/ext2/super.c
    +++ b/fs/ext2/super.c
    @@ -1441,7 +1441,6 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
    struct buffer_head tmp_bh;
    struct buffer_head *bh;

    - mutex_lock_nested(&inode->i_mutex, I_MUTEX_QUOTA);
    while (towrite > 0) {
    tocopy = sb->s_blocksize - offset < towrite ?
    sb->s_blocksize - offset : towrite;
    @@ -1471,16 +1470,13 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
    blk++;
    }
    out:
    - if (len == towrite) {
    - mutex_unlock(&inode->i_mutex);
    + if (len == towrite)
    return err;
    - }
    if (inode->i_size < off+len-towrite)
    i_size_write(inode, off+len-towrite);
    inode->i_version++;
    inode->i_mtime = inode->i_ctime = CURRENT_TIME;
    mark_inode_dirty(inode);
    - mutex_unlock(&inode->i_mutex);
    return len - towrite;
    }

    --
    1.7.1


    \
     
     \ /
      Last update: 2012-04-25 23:03    [W:0.027 / U:32.300 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site