Messages in this thread | | | Date | Wed, 25 Apr 2012 20:45:06 +0100 | From | Ben Hutchings <> | Subject | Re: [ 03/62] hwmon: fam15h_power: fix bogus values with current BIOSes |
| |
On Tue, Apr 24, 2012 at 03:32:44PM -0700, Greg KH wrote: > 3.3-stable review patch. If anyone has any objections, please let me know. [...] > +static void __devinit tweak_runavg_range(struct pci_dev *pdev) > +{ > + u32 val; > + const struct pci_device_id affected_device = { > + PCI_VDEVICE(AMD, PCI_DEVICE_ID_AMD_15H_NB_F4) }; > + > + /* > + * let this quirk apply only to the current version of the > + * northbridge, since future versions may change the behavior > + */ > + if (!pci_match_id(&affected_device, pdev)) > + return; [...]
pci_match_id() takes an *array* of IDs which must be properly zero- terminated. This change is bogus and should be fixed up before it goes into a stable update.
Ben.
-- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus
| |