lkml.org 
[lkml]   [2012]   [Apr]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRE: [PATCH 3/5] mfd: tps65090: Convert to devm_regmap_init_i2c()
    Thanks for the patch.
    Acked by: Venu Byravarasu<vbyravarasu@nvidia.com>


    > -----Original Message-----
    > From: Axel Lin [mailto:axel.lin@gmail.com]
    > Sent: Wednesday, April 25, 2012 7:35 AM
    > To: linux-kernel@vger.kernel.org
    > Cc: Samuel Ortiz; Venu Byravarasu
    > Subject: [PATCH 3/5] mfd: tps65090: Convert to devm_regmap_init_i2c()
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    > ---
    > drivers/mfd/tps65090.c | 10 +++-------
    > 1 files changed, 3 insertions(+), 7 deletions(-)
    >
    > diff --git a/drivers/mfd/tps65090.c b/drivers/mfd/tps65090.c
    > index da821d9..3e12bba 100644
    > --- a/drivers/mfd/tps65090.c
    > +++ b/drivers/mfd/tps65090.c
    > @@ -283,8 +283,8 @@ static int __devinit tps65090_i2c_probe(struct
    > i2c_client *client,
    > }
    > }
    >
    > - tps65090->rmap = regmap_init_i2c(tps65090->client,
    > - &tps65090_regmap_config);
    > + tps65090->rmap = devm_regmap_init_i2c(tps65090->client,
    > + &tps65090_regmap_config);
    > if (IS_ERR(tps65090->rmap)) {
    > ret = PTR_ERR(tps65090->rmap);
    > dev_err(&client->dev, "regmap_init failed with err: %d\n", ret);
    > @@ -296,14 +296,11 @@ static int __devinit tps65090_i2c_probe(struct
    > i2c_client *client,
    > if (ret) {
    > dev_err(&client->dev, "add mfd devices failed with err: %d\n",
    > ret);
    > - goto err_regmap_exit;
    > + goto err_irq_exit;
    > }
    >
    > return 0;
    >
    > -err_regmap_exit:
    > - regmap_exit(tps65090->rmap);
    > -
    > err_irq_exit:
    > if (client->irq)
    > free_irq(client->irq, tps65090);
    > @@ -316,7 +313,6 @@ static int __devexit tps65090_i2c_remove(struct
    > i2c_client *client)
    > struct tps65090 *tps65090 = i2c_get_clientdata(client);
    >
    > mfd_remove_devices(tps65090->dev);
    > - regmap_exit(tps65090->rmap);
    > if (client->irq)
    > free_irq(client->irq, tps65090);
    >
    > --
    > 1.7.5.4
    >
    >

    \
     
     \ /
      Last update: 2012-04-25 07:27    [W:0.027 / U:148.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site