lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ktest.pl: Fix combined usage of BISECT_REVERSE and BISECT_SKIP
On 04/23/2012 05:55 PM, Steven Rostedt wrote:
> On Mon, 2012-04-23 at 16:15 -0700, Russ Dill wrote:
>> When BISECT_REVERSE and BISECT_SKIP are used together with boot or test testing,
>> build failures are treated as boot or test failures and 'git bisect bad' is executed instead
>> of 'git bisect skip'. This is because the $ret value of -1 is treated as a build failure, but
>> the $reverse_bisect logic does not properly handle this.
>>
>> Simple fix, don't invert $ret if it is -1.
>>
>> Signed-off-by: Russ Dill <Russ.Dill@ti.com>
>> ---
>> tools/testing/ktest/ktest.pl | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
>> index 95d6a6f..5221b00 100755
>> --- a/tools/testing/ktest/ktest.pl
>> +++ b/tools/testing/ktest/ktest.pl
>> @@ -2192,7 +2192,7 @@ sub run_bisect {
>> }
>>
>> # Are we looking for where it worked, not failed?
>> - if ($reverse_bisect) {
>> + if ($reverse_bisect && $ret != -1) {
> Thanks! But can you resend with the following change:
>
> ... && $ret >= 0) {
>
> Just incase we have $ret be another negative number for something else.

BTW, I can across an additional problem that I'm not sure how to solve.
I'm using PRE_BUILD and POST_BUILD to apply a patch during a bisect. As
soon as the bisect hits a tree where the patch applies, the module
tar-up fails. The kernel version (and module path) has a '-dirty' but
ktest.pl is calling its get_version after POST_BUILD when the tree is clean.



\
 
 \ /
  Last update: 2012-04-25 06:09    [W:0.056 / U:61.892 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site