lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH 2/3] IRQ: allow check_wakeup_irqs to notice level-triggered interrupts.
Level triggered interrupts do not cause IRQS_PENDING to be set, so
check_wakeup_irqs ignores them.
They don't need to set IRQS_PENDING as the level stays high which
shows that they must be pending. However if such an interrupt fired
during late suspend, it will have been masked so the fact that it
is still asserted will not cause the suspend to abort.

So if any wakeup interrupt is masked, unmask it when checking wakeup
irqs. If the interrupt is asserted, suspend will abort.

Signed-off-by: NeilBrown <neilb@suse.de>
---

kernel/irq/pm.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index 15e53b1..0d26206 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -106,6 +106,12 @@ int check_wakeup_irqs(void)
if (irqd_is_wakeup_set(&desc->irq_data)) {
if (desc->istate & IRQS_PENDING)
return -EBUSY;
+ if (irqd_irq_masked(&desc->irq_data))
+ /* Probably a level interrupt
+ * which fired recently and was
+ * masked
+ */
+ unmask_irq(desc);
continue;
}
/*



\
 
 \ /
  Last update: 2012-04-25 05:13    [W:0.135 / U:37.132 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site