[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[ 32/62] md: dont call ->add_disk unless there is good reason.
    3.3-stable review patch.  If anyone has any objections, please let me know.


    From: NeilBrown <>

    commit ed209584c38fb74b7eecc03e5b1bfe674e591bd8 upstream.

    Commit 7bfec5f35c68121e7b18

    md/raid5: If there is a spare and a want_replacement device, start replacement.

    cause md_check_recovery to call ->add_disk much more often.
    Instead of only when the array is degraded, it is now called whenever
    md_check_recovery finds anything useful to do, which includes
    updating the metadata for clean<->dirty transition.
    This causes unnecessary work, and causes info messages from ->add_disk
    to be reported much too often.

    So refine md_check_recovery to only do any actual recovery checking
    (including ->add_disk) if MD_RECOVERY_NEEDED is set.

    This fix is suitable for 3.3.y:

    Reported-by: Jan Ceuleers <>
    Signed-off-by: NeilBrown <>
    Signed-off-by: Greg Kroah-Hartman <>

    drivers/md/md.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/md/md.c
    +++ b/drivers/md/md.c
    @@ -7580,14 +7580,14 @@ void md_check_recovery(struct mddev *mdd
    * any transients in the value of "sync_action".
    set_bit(MD_RECOVERY_RUNNING, &mddev->recovery);
    - clear_bit(MD_RECOVERY_NEEDED, &mddev->recovery);
    /* Clear some bits that don't mean anything, but
    * might be left set
    clear_bit(MD_RECOVERY_INTR, &mddev->recovery);
    clear_bit(MD_RECOVERY_DONE, &mddev->recovery);

    - if (test_bit(MD_RECOVERY_FROZEN, &mddev->recovery))
    + if (!test_and_clear_bit(MD_RECOVERY_NEEDED, &mddev->recovery) ||
    + test_bit(MD_RECOVERY_FROZEN, &mddev->recovery))
    goto unlock;
    /* no recovery is running.
    * remove any failed drives, then

     \ /
      Last update: 2012-04-25 00:57    [W:0.024 / U:1.228 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site