lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 40/62] EHCI: always clear the STS_FLR status bit
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alan Stern <stern@rowland.harvard.edu>

    commit 2fbe2bf1fd37f9d99950bd8d8093623cf22cf08b upstream.

    This patch (as1544) fixes a problem affecting some EHCI controllers.
    They can generate interrupts whenever the STS_FLR status bit is turned
    on, even though that bit is masked out in the Interrupt Enable
    register.

    Since the driver doesn't use STS_FLR anyway, the patch changes the
    interrupt routine to clear that bit whenever it is set, rather than
    leaving it alone.

    Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
    Reported-and-tested-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/host/ehci-hcd.c | 7 ++++++-
    1 file changed, 6 insertions(+), 1 deletion(-)

    --- a/drivers/usb/host/ehci-hcd.c
    +++ b/drivers/usb/host/ehci-hcd.c
    @@ -857,8 +857,13 @@ static irqreturn_t ehci_irq (struct usb_
    goto dead;
    }

    + /*
    + * We don't use STS_FLR, but some controllers don't like it to
    + * remain on, so mask it out along with the other status bits.
    + */
    + masked_status = status & (INTR_MASK | STS_FLR);
    +
    /* Shared IRQ? */
    - masked_status = status & INTR_MASK;
    if (!masked_status || unlikely(ehci->rh_state == EHCI_RH_HALTED)) {
    spin_unlock(&ehci->lock);
    return IRQ_NONE;



    \
     
     \ /
      Last update: 2012-04-25 00:41    [W:0.022 / U:7.844 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site