lkml.org 
[lkml]   [2012]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 02/62] crypto: sha512 - Fix byte counter overflow in SHA-512
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kent Yoder <key@linux.vnet.ibm.com>

    commit 25c3d30c918207556ae1d6e663150ebdf902186b upstream.

    The current code only increments the upper 64 bits of the SHA-512 byte
    counter when the number of bytes hashed happens to hit 2^64 exactly.

    This patch increments the upper 64 bits whenever the lower 64 bits
    overflows.

    Signed-off-by: Kent Yoder <key@linux.vnet.ibm.com>
    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    crypto/sha512_generic.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/crypto/sha512_generic.c
    +++ b/crypto/sha512_generic.c
    @@ -174,7 +174,7 @@ sha512_update(struct shash_desc *desc, c
    index = sctx->count[0] & 0x7f;

    /* Update number of bytes */
    - if (!(sctx->count[0] += len))
    + if ((sctx->count[0] += len) < len)
    sctx->count[1]++;

    part_len = 128 - index;



    \
     
     \ /
      Last update: 2012-04-25 00:37    [W:0.022 / U:90.228 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site