[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 03/11] parse-events: Get rid of handling concatenation on event_read_print
On Tue, 2012-04-24 at 09:09 +0900, Namhyung Kim wrote:
> Hi,
> On Mon, 23 Apr 2012 12:33:42 -0400, Steven Rostedt wrote:
> > On Mon, 2012-04-23 at 13:58 +0900, Namhyung Kim wrote:
> >> The concatenation of subsequent DQUOTE'd strings is handled
> >> by __read_token() already.
> >>
> >
> > You missed the point of this concat. It's not connecting "xxx" it is
> > connecting "xxx" "yyy" into "xxxyyy", as some events do this.
> >
> I think I don't :). Please see commit 0f15820 ("parse-events:
> Concatinate two strings that are adjacent").

Heh, OK, I remember doing it for the print statement, but I guess I
needed to do it for the token too. As the commits for both are almost
identical. As the print was first, it must not have been enough, and I
moved it to the token, but kept the first concat there.

I still want to hold off on this patch just to make sure there's not
something else that was missed.


-- Steve

 \ /
  Last update: 2012-04-24 02:29    [W:0.121 / U:21.292 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site