lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3 4/6] hid: Create a generic device group
Hi Gustavo,

> > @@ -586,12 +586,12 @@ struct hid_descriptor {
> > struct hid_class_descriptor desc[1];
> > } __attribute__ ((packed));
> >
> > -#define HID_DEVICE(b, ven, prod) \
> > - .bus = (b), \
> > - .vendor = (ven), .product = (prod)
> > -
> > -#define HID_USB_DEVICE(ven, prod) HID_DEVICE(BUS_USB, ven, prod)
> > -#define HID_BLUETOOTH_DEVICE(ven, prod) HID_DEVICE(BUS_BLUETOOTH, ven, prod)
> > +#define HID_DEVICE(b, g, ven, prod) \
> > + .bus = (b), .group = (g), .vendor = (ven), .product = (prod)
> > +#define HID_USB_DEVICE(ven, prod) \
> > + .bus = BUS_USB, .vendor = (ven), .product = (prod)
> > +#define HID_BLUETOOTH_DEVICE(ven, prod) \
> > + .bus = BUS_BLUETOOTH, .vendor = (ven), .product = (prod)
>
> It seems we don't use this macro anywhere else, why did you keep it?

It is actually used extensively in device lists, see for instance in
drivers/hid/hid-core.c.

Henrik


\
 
 \ /
  Last update: 2012-04-24 00:31    [W:0.120 / U:0.676 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site