lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] drivers/rtc/rtc-m41t93.c: don't let get_time() reset error state
    On Mon, 23 Apr 2012 12:51:23 +0200
    Nikolaus Voss <n.voss@weinmann.de> wrote:

    > If the rtc reports the time might be invalid due to oscillator
    > failure, this flags must not be reset by get_time() as the read
    > operation doesn't make the time valid.
    >
    > Instead, the flag is reset in set_time() when a valid time is
    > to be written.

    This is rather vague - what is/are "these flags"? From the patch I
    think you're referring to (the maddeningly undocumented)
    M41T93_FLAG_ST? If so, I'd suggest something like

    : If the rtc reports the time might be invalid due to oscillator failure,
    : the M41T93_FLAG_ST flag must not be reset by get_time() as the read
    : operation doesn't make the time valid.
    :
    : Instead, the M41T93_FLAG_ST flag is reset in set_time() when a valid time
    : is to be written.

    Secondly, you provided no description of the user-visible effects of
    the bug. Hence I cannot work out which kernel version(s) this patch
    should be merged into.



    \
     
     \ /
      Last update: 2012-04-23 22:55    [W:0.026 / U:180.896 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site