lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: Sharing header files -- arch/arm/mach-generic ?
Date
On Monday 23 April 2012, Pavel Machek wrote:
> I have new architecture I'd like to merge into the mainline. It has
> some code very similar to existing plaforms (for example
> real differences to mach-realview/platsmp.c are two lines.)
>
> Is that a problem?
>
> Should mach-generic/platsmp.c be created, so code can be better
> shared? Or are the code pieces small enough that this duplication can
> be ignored?

Hi Pavel,

I'd suggest you just post the code with the duplicate files
for review at first, and then we can discuss what to do with them.
As Russell mentioned, the code might not actually be ideal
in the duplicate version so you end up rewriting it, or there
might be a different solution that someone finds when we see the
patches.

Arnd


\
 
 \ /
  Last update: 2012-04-23 22:19    [W:0.033 / U:3.712 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site