lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectSharing header files -- arch/arm/mach-generic ?
Hi!

I have new architecture I'd like to merge into the mainline. It has
some code very similar to existing plaforms (for example
real differences to mach-realview/platsmp.c are two lines.)

Is that a problem?

Should mach-generic/platsmp.c be created, so code can be better
shared? Or are the code pieces small enough that this duplication can
be ignored?

headsmp.S is another candidate for sharing. AFAICT we have 4 times
identical code in the tree already:

./mach-exynos/headsmp.S: ldmia r4, {r5, r6}
./plat-versatile/headsmp.S: ldmia r4, {r5, r6}
./mach-ux500/headsmp.S: ldmia r4, {r5, r6}
./mach-msm/headsmp.S: ldmia r4, {r5, r6}

Thoughts?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2012-04-23 21:43    [W:0.024 / U:0.728 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site