lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] iommu/tegra: smmu: Reserve SMMU reg regions precisely
On 04/23/2012 05:58 AM, Hiroshi DOYU wrote:
> SMMU register regions are located into 3 blocks discontiguously.
>
> Get them and reserve each region respectively. This allows other
> module to use/reserve other register regions between SMMU register
> blocks.
>
> Signed-off-by: Hiroshi DOYU <hdoyu@nvidia.com>

This patch depends on the other series you sent which adds the Tegra AHB
driver, and modifies the SMMU driver to use it. At least you need to
mention the dependencies so e.g. these patches don't get applied without
the other series.

> @@ -875,9 +877,25 @@ static int tegra_smmu_probe(struct platform_device *pdev)
>
> BUILD_BUG_ON(PAGE_SHIFT != SMMU_PAGE_SHIFT);
>
> - regs = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - window = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> - if (!regs || !window) {
> + for (i = 0; i < ARRAY_SIZE(res); i++) {
> + res[i] = platform_get_resource(pdev, IORESOURCE_MEM, i);
> + if (!res[i])
> + return -ENODEV;
> +
> + res[i] = devm_request_mem_region(&pdev->dev, res[i]->start,
> + resource_size(res[i]),
> + dev_name(&pdev->dev));
> + if (res[i])
> + continue;
> +
> + while (--i >= 0)
> + devm_release_mem_region(&pdev->dev, res[i]->start,
> + resource_size(res[i]));

The whole point of using the devm_* functions is that you no longer need
to write out all the error-handling and freeing code related to those
allocations. A similar comment applies to many other parts of this patch.

> + return -EIO;
> + }
> +
> + window = platform_get_resource(pdev, IORESOURCE_MEM, 3);
> + if (!window) {
> dev_err(dev, "No SMMU resources\n");
> return -ENODEV;
> }
> @@ -892,7 +910,8 @@ static int tegra_smmu_probe(struct platform_device *pdev)
> smmu->num_as = SMMU_NUM_ASIDS;
> smmu->iovmm_base = (unsigned long)window->start;
> smmu->page_count = resource_size(window) >> SMMU_PAGE_SHIFT;
> - smmu->regs = devm_ioremap(dev, regs->start, resource_size(regs));
> + smmu->regs = devm_ioremap(dev, res[0]->start,
> + res[2]->end - res[0]->start + 1);

So, you've retrieved 3 separate resources for the address space, but
only call ioremap once. That doesn't seem right; there should be a 1:1
relationship between the number of resources and ioremap calls. This is
only working because the SMMU driver isn't calling request_mem_region
for this whole range, and hence isn't conflicting with the
request_mem_region and ioremap callss that the AHB driver is (or rather,
should be) performing...

> smmu->as = devm_kzalloc(dev,
> - sizeof(smmu->as[0]) * smmu->num_as, GFP_KERNEL);
> + sizeof(smmu->as[0]) * smmu->num_as, GFP_KERNEL);

That looks unrelated.


\
 
 \ /
  Last update: 2012-04-23 20:27    [W:0.060 / U:90.520 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site