[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: commit 1cb41fe7e34a43a1d27dfdb6d65699786dd44c20 in stable (v3.3.3) breaks perf
On Mon, Apr 23, 2012 at 09:37:04AM +0300, Zeev Tarantov wrote:
> gcc correctly complains:
> util/hist.c: In function ‘__hists__add_entry’:
> util/hist.c:240:27: error: invalid type argument of ‘->’ (have ‘struct hist_entry’)
> util/hist.c:241:23: error: invalid type argument of ‘->’ (have ‘struct hist_entry’)
> for this new code:
> + if (he-> != entry-> {
> + he-> = entry->;
> + if (he->
> + he->>referenced = true;
> + }
> because "entry" is a "struct hist_entry", not a pointer to a struct.
> In mainline, "entry" is a pointer to struct passed as argument to the function.
> So this is broken during backporting. But obviously not compile tested.
> Greg wrote on G+ that those who did not test 3.3.3-rc1 have no right to complain, but I'm complaining anyway. :P
> See trivial patch to fix this.
> -Z.T.
> P.S.
> I don't need credit for the patch so it's ok if my diff doesn't apply because of messed up whitespace.
> Just fix it.

Patch looks good to me, thanks for doing this, you are right in that I
didn't test perf. I'll go queue this up right now.

greg k-h
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2012-04-23 18:29    [W:0.041 / U:11.504 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site