lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 4/7] parse-events: Handle strdup failure cases
From
Date
On Mon, 2012-04-09 at 11:54 +0900, Namhyung Kim wrote:
> There were some places didn't check return value of the strdup
> and had unneeded/duplicated checks. Fix it.
>
> Signed-off-by: Namhyung Kim <namhyung.kim@lge.com>
> ---
> parse-events.c | 29 +++++++++++++++++++++++++++--
> 1 files changed, 27 insertions(+), 2 deletions(-)
>
> diff --git a/parse-events.c b/parse-events.c
> index 0b1e40a..773c928 100644
> --- a/parse-events.c
> +++ b/parse-events.c
> @@ -463,8 +463,10 @@ int pevent_register_function(struct pevent *pevent, char *func,
> item->mod = NULL;
> item->addr = addr;
>
> - pevent->funclist = item;
> + if (!item->func || (mod && !item->mod))
> + die("malloc func");
>

I just added this patch, but we need to get rid of all the "die"
functions and do proper freeing and error notifications to make this a
real library.

Thanks,

-- Steve




\
 
 \ /
  Last update: 2012-04-23 17:55    [from the cache]
©2003-2011 Jasper Spaans