lkml.org 
[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC v3] vfs: make fstatat retry once on ESTALE errors from getattr call
On Mon, 23 Apr 2012 16:51:04 +0200
Miklos Szeredi <miklos@szeredi.hu> wrote:

> "J. Bruce Fields" <bfields@fieldses.org> writes:
>
> >
> > I also wonder whether it would be making too many assumptions about the
> > server or filesystem: just because ordinary posix interfaces don't allow
> > atomic replacement of a whole directory tree doesn't mean the server
> > might not have some way to do it.
>
> Exactly because posix limits the atomic replacement to empty directories
> is that this feature is not useful and is why linux can get away with
> the dead directory behavior in this case. And thinking about fixing
> this in NFS is completely pointless since no one will rely on the atomic
> replacement behavior. Fixing local filesystems is also pointless for
> the same reason.
>
> Atomic replacement of whole directory trees would indeed be more useful,
> but it's highly unlikely to be used anywhere since applications relying
> on this feature would be limited to special filesystems that allow this.
>
> So my statement is "ENOENT is equivalent to ESTALE if already retrying
> path lookup with LOOKUP_REVAL on any operation that takes an parent
> directory and a name (lookup, create, link, unlink, symlink, mkdir,
> rmdir, mknod, rename)."
>

Ok, but again, that only applies to the lookup. It has no bearing on
the subsequent operation. For instance, if we're doing:

rename("/foo", "/bar");

...and another client is simultaneously doing:

creat("/bar/baz", 0600);

...and we get back ESTALE from the server on the create because the
"old" /bar got replaced after the lookup of it. Then it seems like
returning -ENOENT would not be correct since there was never a time
where /bar didn't exist...

It might eventually be nice to add that optimization to the path lookup
code. OTOH, it only solves a very specific problem that's not really
applicable in a lot of the cases I'm interested in fixing.

--
Jeff Layton <jlayton@redhat.com>


\
 
 \ /
  Last update: 2012-04-23 17:19    [W:0.090 / U:12.952 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site