Messages in this thread | | | Date | Mon, 23 Apr 2012 11:47:25 +0530 | Subject | Re: [PATCH] mfd: omap-ush-host: Fix build breakage | From | "Munegowda, Keshava" <> |
| |
On Sun, Apr 22, 2012 at 10:38 PM, Anatolij Gustschin <agust@denx.de> wrote: > Commit 1fcb57d0f6e1150003d222051aaaf4bc4a9ccc94 (ARM: OMAP3: USB: Fix > the EHCI ULPI PHY reset issue) removed #include <linux/gpio.h> which > indirectly includes 'plat/cpu.h'. This caused build breakage: > > drivers/mfd/omap-usb-host.c: In function 'omap_usbhs_init': > drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'cpu_is_omap3430' > drivers/mfd/omap-usb-host.c:525:3: error: implicit declaration of function 'omap_rev' > drivers/mfd/omap-usb-host.c:525:43: error: 'OMAP3430_REV_ES2_1' undeclared (first use in this function) > > Include <plat/cpu.h> to fix it. > > Signed-off-by: Anatolij Gustschin <agust@denx.de> > Cc: Keshava Munegowda <Keshava_mgowda@ti.com> > --- > drivers/mfd/omap-usb-host.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c > index c8aae66..7e96bb2 100644 > --- a/drivers/mfd/omap-usb-host.c > +++ b/drivers/mfd/omap-usb-host.c > @@ -25,6 +25,7 @@ > #include <linux/clk.h> > #include <linux/dma-mapping.h> > #include <linux/spinlock.h> > +#include <plat/cpu.h> > #include <plat/usb.h> > #include <linux/pm_runtime.h> > > -- > 1.7.1 >
Yes, this seems correct! But, on which config you are seeing this error?
regards keshava -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |