[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH RFC v3] vfs: make fstatat retry once on ESTALE errors from getattr call
    "J. Bruce Fields" <> writes:

    > I also wonder whether it would be making too many assumptions about the
    > server or filesystem: just because ordinary posix interfaces don't allow
    > atomic replacement of a whole directory tree doesn't mean the server
    > might not have some way to do it.

    Exactly because posix limits the atomic replacement to empty directories
    is that this feature is not useful and is why linux can get away with
    the dead directory behavior in this case. And thinking about fixing
    this in NFS is completely pointless since no one will rely on the atomic
    replacement behavior. Fixing local filesystems is also pointless for
    the same reason.

    Atomic replacement of whole directory trees would indeed be more useful,
    but it's highly unlikely to be used anywhere since applications relying
    on this feature would be limited to special filesystems that allow this.

    So my statement is "ENOENT is equivalent to ESTALE if already retrying
    path lookup with LOOKUP_REVAL on any operation that takes an parent
    directory and a name (lookup, create, link, unlink, symlink, mkdir,
    rmdir, mknod, rename)."

    This equivalence is in the sense that it doesn't change behavior
    compared to local filesystems.

    For other operations ENOENT is not equivalent to ESTALE.


     \ /
      Last update: 2012-04-23 16:53    [W:0.022 / U:18.124 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site