[lkml]   [2012]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [CRIU] [PATCH v2 0/2] IPC: message queue checkpoint/restore - requested updates
Hello, Andrew.
I'm very sorry, but a critical flaw has been found in this feature: copying of
kernel data to user is done under spinlock.
Since message queue size can be increased up to INT_MAX, then copying to
temporary kernel buffer while passing message queue in not a solution.
So, please, drop both patches (feature implementation and test).
Most probably Ill replace them with MSG_PEEK feature (the same logic, but only
for one message - like it's done for sockets).

Best regards,
Stanislav Kinsbursky

 \ /
  Last update: 2012-04-23 12:21    [W:0.046 / U:2.720 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site