lkml.org 
[lkml]   [2012]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 2/2] i2c/of: Automatically populate i2c mux busses from device tree data.
    On Thu, Apr 12, 2012 at 02:14:23PM -0700, David Daney wrote:
    > From: David Daney <david.daney@cavium.com>
    >
    > For 'normal' i2c bus drivers, we can call of_i2c_register_devices()
    > and have the device tree framework automatically populate the bus with
    > the devices specified in the device tree.
    >
    > This patch adds a common code to the i2c mux framework to have the mux
    > sub-busses be populated by the of_i2c_register_devices() too. If the
    > mux device has an of_node, we populate the sub-bus' of_node so that
    > the subsequent call to of_i2c_register_devices() will find the
    > corresponding devices.
    >
    > It seemed better to put this logic in i2c_add_mux_adapter() rather
    > than the individual mux drivers, as they will all probably want to do
    > the same thing.

    Both patches looking mostly good, two things here:

    > + /*
    > + * Try to get populate the mux adapter's of_node, expands to

    "get populate"? I'd think you mean "populate" only, but am not sure
    enough to fix it myself.

    > + * nothing if !CONFIG_OF.
    > + */
    > + if (mux_dev->of_node) {
    > + struct device_node *child;
    > + u32 reg;
    > + int ret;

    We have a "ret" already in this function.

    Regards,

    Wolfram

    --
    Pengutronix e.K. | Wolfram Sang |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2012-04-22 18:23    [W:0.026 / U:3.556 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site