lkml.org 
[lkml]   [2012]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 2/2] ks8851: Fix mutex deadlock in ks8851_net_stop()
    From
    From: Stephen Boyd <sboyd@codeaurora.org>
    Date: Wed, 18 Apr 2012 20:25:58 -0700

    > There is a potential deadlock scenario when the ks8851 driver
    > is removed. The interrupt handler schedules a workqueue which
    > acquires a mutex that ks8851_net_stop() also acquires before
    > flushing the workqueue. Previously lockdep wouldn't be able
    > to find this problem but now that it has the support we can
    > trigger this lockdep warning by rmmoding the driver after
    > an ifconfig up.
    >
    > Fix the possible deadlock by disabling the interrupts in
    > the chip and then release the lock across the workqueue
    > flushing. The mutex is only there to proect the registers
    > anyway so this should be ok.
    ...
    > Cc: Ben Dooks <ben-linux@fluff.org>
    > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

    Applied.


    \
     
     \ /
      Last update: 2012-04-21 21:37    [W:0.028 / U:0.020 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site