lkml.org 
[lkml]   [2012]   [Apr]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: Multitouch regression in 3.3 on thinkpad X220 clickpad
From
On Fri, Apr 20, 2012 at 6:16 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
>> It looks we lost a condition in synaptics_set_advanced_gesture_mode().
>> It used to be:
>>
>>
>>       if (!(SYN_CAP_ADV_GESTURE(priv->ext_cap_0c) ||
>>                       SYN_CAP_IMAGE_SENSOR(priv->ext_cap_0c)))
>>               return 0;
>>
>> and now simply is:
>>
>>       if (!SYN_CAP_ADV_GESTURE(priv->ext_cap_0c))
>>               return 0;
>>
>> Could you try restoring the condition and see if it fixes the
>> regression?
>
> Yes, that's it. Please shoot the patch below to Linus.

Oops. Thanks Ben and Dmitry, and apologies for causing this bug.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-04-21 17:07    [from the cache]
©2003-2011 Jasper Spaans