Messages in this thread |  | | Date | Sat, 21 Apr 2012 13:20:45 +0100 | | From | Russell King - ARM Linux <> | | Subject | Re: [PATCH 02/17] ARM clps711x: Added Cirrus Logic EP7312 CPU variant |
| |
On Sat, Apr 21, 2012 at 12:11:35PM +0000, Arnd Bergmann wrote: > On Saturday 21 April 2012, Russell King - ARM Linux wrote: > > That's where we used to put truely hardware dependent stuff, rather than > > machine type stuff when the structure was first implemented. At that time > > we had a number of different mach-* directories wanting to share things > > like the acorn IOC/IOMD stuff, and there's also sharing of definitions > > between CLPS711x and EP93xx. > > > > That was long before we invented the plat-* stuff - but even that doesn't > > actually cover what asm/hardware does - eg, the SA1111 stuff shared > > between SA11x0 and PXA. > > Ah, thanks for the explanation. > > Since the clps7111 based asm/hardware/*.h files are not shared with ep93xx, > I guess it makes sense to move them to mach-clps711x/include/mach/*.h as part of > this cleanup series, right?
Yes.
> Out of these, only the first one is used in two places outside of > arch/arm/mach-clps711x, the serial and the fb driver, which could > be changed to use mach/hardware.h instead.
The headers still have to end up being in an accessible place, and having drivers include the minimum required is a good idea. Merely moving them into include/mach and updating the include statements as far as I'd go. (and I've never liked the idea of mach/hardware.h being an "include the world for this platform" header file.)
|  |