lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 10/12] leds-atmel-pwm.c: Make pwmled_probe() __devinit
    On Mon, 16 Apr 2012 11:20:54 +0200
    Nicolas Ferre <nicolas.ferre@atmel.com> wrote:

    > Commit 892a884 (leds: convert led platform drivers to module_platform_driver)
    > is omitting the section mismatch error: so change annotation of the probe
    > function to __devinit instead of __init.
    >
    > ...
    >
    > --- a/drivers/leds/leds-atmel-pwm.c
    > +++ b/drivers/leds/leds-atmel-pwm.c
    > @@ -35,7 +35,7 @@ static void pwmled_brightness(struct led_classdev *cdev, enum led_brightness b)
    > * NOTE: we reuse the platform_data structure of GPIO leds,
    > * but repurpose its "gpio" number as a PWM channel number.
    > */
    > -static int __init pwmled_probe(struct platform_device *pdev)
    > +static int __devinit pwmled_probe(struct platform_device *pdev)
    > {
    > const struct gpio_led_platform_data *pdata;
    > struct pwmled *leds;

    This is theoretically oopsable and the patch is probably needed in 3.4
    and 3.3.x.

    But you've applied it to linu-next via your own tree so I won't be
    merging it.


    \
     
     \ /
      Last update: 2012-04-20 23:37    [from the cache]
    ©2003-2011 Jasper Spaans