Messages in this thread | | | Date | Fri, 20 Apr 2012 13:03:56 -0400 | From | Dave Jones <> | Subject | Re: remove unnecessary ftrace WARN_ONCE's. |
| |
On Wed, Apr 11, 2012 at 10:31:32PM -0400, Dave Jones wrote: > These warnings are trivially triggerable by any user, and serve no useful purpose afaics > Just -EINVAL and be done. > > Signed-off-by: Dave Jones <davej@redhat.com> > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index ed7b5d1..a745317 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos, > return -ENOMEM; > > if (*ppos & (PAGE_SIZE - 1)) { > - WARN_ONCE(1, "Ftrace: previous read must page-align\n"); > ret = -EINVAL; > goto out; > } > > if (len & (PAGE_SIZE - 1)) { > - WARN_ONCE(1, "Ftrace: splice_read should page-align\n"); > if (len < PAGE_SIZE) { > ret = -EINVAL; > goto out; > --
Anyone want to pick this up, or shall I just send it to Linus myself ?
Dave
| |