lkml.org 
[lkml]   [2012]   [Apr]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v2 15/21] loop: use aio to perform io on the underlying file
    On 04/20/2012 09:48 AM, Maxim V. Patlasov wrote:
    > On 03/30/2012 07:43 PM, Dave Kleikamp wrote:
    >> From: Zach Brown<zab@zabbo.net>
    >>
    >> This uses the new kernel aio interface to process loopback IO by
    >> submitting concurrent direct aio. Previously loop's IO was serialized
    >> by synchronous processing in a thread.
    >>
    >
    > The patch ignores REQ_FLUSH bit of bi_rw. Is it simply overlook?

    Good question. Since the loop device is sending only direct IO requests,
    it shouldn't be necessary to explicitly flush page cache, but REQ_FLUSH
    also guarantees that previous writes make it to media before the current
    write, so it looks like I need to add an explicit vfs_fsync() in the new
    path (conditional on REQ_FLUSH of course).

    Zach, thoughts?

    Shaggy

    >
    > Thanks,
    > Maxim


    \
     
     \ /
      Last update: 2012-04-20 17:13    [W:0.036 / U:31.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site