lkml.org 
[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRE: [REGRESSION][PATCH V4 1/3] bpf jit: Make the filter.c::__load_pointer helper non-static for the jits
    Date
    From

    > The function is renamed to make it a little more clear what it does.
    > It is not added to any .h because it is not for general
    > consumption, only for bpf internal use (and so by the jits).

    I'd have thought it better to put in into a bfp_internal.h
    (or similar) with a big warning there about the asm users.

    Possibly even worth adding some other defs that the asm
    files will need (if there are any).

    David




    \
     
     \ /
      Last update: 2012-04-02 11:21    [W:0.043 / U:0.036 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site