lkml.org 
[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH RFC 2/4] regulator: Rework s5m8767_set_voltage to support both LDOs and BUCKs
    Date
    On Sat, Mar 19, 2012 at 1:24 PM, Axel Lin wrote:

    > s5m8767_set_voltage not only implement set_voltage callbacks for LDOs,
    > but also for BUCKs when s5m8767->buck_gpioindex is not set.
    > s5m8767_set_voltage_buck actually only for buck[2|3|4] when
    > s5m8767->buck_gpioindex is set.
    > Conditionally calling s5m8767_set_voltage in s5m8767_set_voltage_buck makes
    > the code hard to read.
    >
    > I think merging s5m8767_set_voltage_buck and s5m8767_set_voltage actually
    > simplifies things. It's easy to use buck234_vol pointer to differentiate if
    > we need to control voltage for buck[2|3|4] by DVS GPIOs.
    >
    > This patch reworks s5m8767_set_voltage to support both LDOx and BUCKx in all
    > cases.
    >
    > Signed-off-by: Axel Lin <axel.lin@gmail.com>
    Hi, Axel
    Basically, Your optimization code looks good.
    But, S5M8767A support 9 Bucks.
    Please Add #9 Buck handling too.
    As you know, 3.4-rc1 is released.
    Please rebase your patch on 3.4-rc1.
    Some feature is added on 3.4-rc1.

    Thanks,
    Sangbeom.




    \
     
     \ /
      Last update: 2012-04-03 01:19    [W:0.020 / U:10.048 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site