lkml.org 
[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] cpuidle: Avoid possible NULL pointer dereference in __cpuidle_register_device()
    Date
    In __cpuidle_register_device(), "dev->cpu" is used before checking if dev is
    non-NULL. Fix it.

    Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
    ---

    drivers/cpuidle/cpuidle.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
    index 87411ce..75b381e 100644
    --- a/drivers/cpuidle/cpuidle.c
    +++ b/drivers/cpuidle/cpuidle.c
    @@ -372,7 +372,7 @@ EXPORT_SYMBOL_GPL(cpuidle_disable_device);
    static int __cpuidle_register_device(struct cpuidle_device *dev)
    {
    int ret;
    - struct device *cpu_dev = get_cpu_device((unsigned long)dev->cpu);
    + struct device *cpu_dev;
    struct cpuidle_driver *cpuidle_driver = cpuidle_get_driver();

    if (!dev)
    @@ -380,6 +380,7 @@ static int __cpuidle_register_device(struct cpuidle_device *dev)
    if (!try_module_get(cpuidle_driver->owner))
    return -EINVAL;

    + cpu_dev = get_cpu_device((unsigned long)dev->cpu);
    init_completion(&dev->kobj_unregister);

    per_cpu(cpuidle_devices, dev->cpu) = dev;


    \
     
     \ /
      Last update: 2012-04-02 16:47    [W:0.021 / U:32.476 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site