lkml.org 
[lkml]   [2012]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 30/69] TTY: sclp_vt220, remove unused allocation
    Date
    80 bytes which are allocated in tty->ops->open and assigned to
    tty->driver_data are never used. Remove that.

    Signed-off-by: Jiri Slaby <jslaby@suse.cz>
    Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
    Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
    Cc: linux390@de.ibm.com
    Cc: linux-s390@vger.kernel.org
    ---
    drivers/s390/char/sclp_vt220.c | 9 +--------
    1 file changed, 1 insertion(+), 8 deletions(-)

    diff --git a/drivers/s390/char/sclp_vt220.c b/drivers/s390/char/sclp_vt220.c
    index 25cf2e8..edfc0fd 100644
    --- a/drivers/s390/char/sclp_vt220.c
    +++ b/drivers/s390/char/sclp_vt220.c
    @@ -34,7 +34,6 @@
    #define SCLP_VT220_DEVICE_NAME "ttysclp"
    #define SCLP_VT220_CONSOLE_NAME "ttyS"
    #define SCLP_VT220_CONSOLE_INDEX 1 /* console=ttyS1 */
    -#define SCLP_VT220_BUF_SIZE 80

    /* Representation of a single write request */
    struct sclp_vt220_request {
    @@ -496,9 +495,6 @@ sclp_vt220_open(struct tty_struct *tty, struct file *filp)
    {
    if (tty->count == 1) {
    tty_port_tty_set(&sclp_vt220_port, tty);
    - tty->driver_data = kmalloc(SCLP_VT220_BUF_SIZE, GFP_KERNEL);
    - if (tty->driver_data == NULL)
    - return -ENOMEM;
    tty->low_latency = 0;
    if (!tty->winsize.ws_row && !tty->winsize.ws_col) {
    tty->winsize.ws_row = 24;
    @@ -514,11 +510,8 @@ sclp_vt220_open(struct tty_struct *tty, struct file *filp)
    static void
    sclp_vt220_close(struct tty_struct *tty, struct file *filp)
    {
    - if (tty->count == 1) {
    + if (tty->count == 1)
    tty_port_tty_set(&sclp_vt220_port, NULL);
    - kfree(tty->driver_data);
    - tty->driver_data = NULL;
    - }
    }

    /*
    --
    1.7.9.2



    \
     
     \ /
      Last update: 2012-04-02 14:11    [W:0.021 / U:3.340 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site