Messages in this thread | | | Date | Thu, 19 Apr 2012 11:56:29 +0200 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH V2 2/2] staging: iio: light: isl29018: use regmap for register access |
| |
On 04/19/2012 10:59 AM, Laxman Dewangan wrote: > [...] > -static int isl29018_read_sensor_input(struct i2c_client *client, int mode) > +static int isl29018_read_sensor_input(struct isl29018_chip *chip, int mode) > { > [...] > - dev_err(&client->dev, "Error in reading MSB DATA\n"); > + status = regmap_read(chip->regmap, ISL29018_REG_ADD_DATA_MSB, &msb); > + if (status < 0) { > + dev_err(chip->dev, > + "Error in reading MSB DATA with error %d\n", status); > return msb;
should return status instead of msb.
> [...]
| |