Messages in this thread Patch in this message | | | From | Sha Zhengju <> | Subject | [PATCH RESEND] memcg: Free spare array to avoid memory leak | Date | Thu, 19 Apr 2012 16:54:50 +0800 |
| |
From: Sha Zhengju <handai.szj@taobao.com>
When the last event is unregistered, there is no need to keep the spare array anymore. So free it to avoid memory leak.
Signed-off-by: Sha Zhengju <handai.szj@taobao.com> Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Reviewed-by: Kirill A. Shutemov <kirill@shutemov.name>
--- Hi, Andrew
This patch has been reviewed days ago. Do you have any comments about it?
Thanks, Sha mm/memcontrol.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 22d94f5..3c09a84 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4412,6 +4412,12 @@ static void mem_cgroup_usage_unregister_event(struct cgroup *cgrp, swap_buffers: /* Swap primary and spare array */ thresholds->spare = thresholds->primary; + /* If all events are unregistered, free the spare array */ + if (!new) { + kfree(thresholds->spare); + thresholds->spare = NULL; + } + rcu_assign_pointer(thresholds->primary, new); /* To be sure that nobody uses thresholds */ -- 1.7.4.1
| |