lkml.org 
[lkml]   [2012]   [Apr]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[ 66/75] usb: gadget: pch_udc: Reduce redundant interrupt
    3.3-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Tomoya MORINAGA <tomoya.rohm@gmail.com>

    commit 833310402c54ad9b676b465fc53ad276b13d36be upstream.

    ISSUE:
    USB Suspend interrupts occur frequently.

    CAUSE:
    When it is called pch_udc_reconnect() in USB Suspend, it repeats reset and
    Suspend.

    SOLUTION:
    pch_udc_reconnect() does not enable all interrupts. When an enumeration event
    occurred the driver enables all interrupts.

    Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
    Signed-off-by: Felipe Balbi <balbi@ti.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/usb/gadget/pch_udc.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    --- a/drivers/usb/gadget/pch_udc.c
    +++ b/drivers/usb/gadget/pch_udc.c
    @@ -568,9 +568,7 @@ static void pch_udc_reconnect(struct pch
    /* enable device interrupts */
    /* pch_udc_enable_interrupts() */
    pch_udc_bit_clr(dev, UDC_DEVIRQMSK_ADDR,
    - UDC_DEVINT_UR | UDC_DEVINT_US |
    - UDC_DEVINT_ENUM |
    - UDC_DEVINT_SI | UDC_DEVINT_SC);
    + UDC_DEVINT_UR | UDC_DEVINT_ENUM);

    /* Clear the disconnect */
    pch_udc_bit_set(dev, UDC_DEVCTL_ADDR, UDC_DEVCTL_RES);
    @@ -2420,6 +2418,11 @@ static void pch_udc_svc_enum_interrupt(s
    pch_udc_set_dma(dev, DMA_DIR_TX);
    pch_udc_set_dma(dev, DMA_DIR_RX);
    pch_udc_ep_set_rrdy(&(dev->ep[UDC_EP0OUT_IDX]));
    +
    + /* enable device interrupts */
    + pch_udc_enable_interrupts(dev, UDC_DEVINT_UR | UDC_DEVINT_US |
    + UDC_DEVINT_ES | UDC_DEVINT_ENUM |
    + UDC_DEVINT_SI | UDC_DEVINT_SC);
    }

    /**



    \
     
     \ /
      Last update: 2012-04-19 23:13    [W:0.024 / U:30.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site