Messages in this thread | | | From | Grant Likely <> | Subject | Re: [PATCH v6] irq: add irq_domain support to generic-chip | Date | Thu, 19 Apr 2012 12:34:20 -0600 |
| |
On Fri, 13 Apr 2012 10:53:33 +0530, Thomas Abraham <thomas.abraham@linaro.org> wrote: > Hi Rob, > > On 9 February 2012 04:25, Rob Herring <robherring2@gmail.com> wrote: > > From: Rob Herring <rob.herring@calxeda.com> > > > > Add irq domain support to irq generic-chip. This enables users of > > generic-chip to support dynamic irq assignment needed for DT interrupt > > binding. > > > > Thanks to Shawn Guo for fixes and testing. > > > > Signed-off-by: Rob Herring <rob.herring@calxeda.com> > > Cc: Grant Likely <grant.likely@secretlab.ca> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > --- > > Here's the latest version. This has fixes from Shawn Guo, so should be > > working. This version is also available here: > > > > git://sources.calxeda.com/kernel/linux.git pl061-domain-v6. > > > >  include/linux/irq.h    |  15 +++++ > >  kernel/irq/generic-chip.c |  152 ++++++++++++++++++++++++++++++++++++++------- > >  2 files changed, 145 insertions(+), 22 deletions(-) > > > > [...] > > > diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c > > index c89295a..3ac7fa1 100644 > > --- a/kernel/irq/generic-chip.c > > +++ b/kernel/irq/generic-chip.c > > [...] > > > +static const struct irq_domain_ops irq_gc_irq_domain_ops = { > > +    .map = irq_gc_irq_domain_map, > > +    .xlate = irq_domain_xlate_onetwocell, > > +}; > > Is there anyway to use a custom xlate function instead of the fixed > 'irq_domain_xlate_onetwocell' xlate function. I am using this patchset > with Exynos4 interrupt combiner controller whose interrupt specifier > format is two cell but has different meaning. The first cell is the > interrupt combiner number and the second cell is the interrupt number > within that combiner.
I think it would be good to rework the API so that irq_domain + generic_chip works like a library and setup helper function that allows a driver to provide custom implementations for things like xlate before the irqdomain and generic chips get registered.
g.
| |