Messages in this thread | | | Date | Wed, 18 Apr 2012 18:29:48 +0300 | From | Sergey Senozhatsky <> | Subject | Re: [PATCH] kmemleak: do not leak object after tree insertion error (v2, fixed) |
| |
On (04/18/12 15:40), Catalin Marinas wrote: > On Tue, Apr 03, 2012 at 12:06:56AM +0100, Sergey Senozhatsky wrote: > > [PATCH] kmemleak: do not leak object after tree insertion error > > > > In case when tree insertion fails due to already existing object > > error, pointer to allocated object gets lost due to lookup_object() > > overwrite. Free allocated object and return the existing one, > > obtained from lookup_object(). > > We really need to return NULL if the tree insertion fails as kmemleak is > disabled in this case (fatal condition for kmemleak). So we could just > call kmem_cache_free(object_cache, object) in the 'if' block. >
Good point. Thanks a lot for your review! I was chasing two bugs and sort of messed things up. I'll send v3 shortly.
Sergey
| |