Messages in this thread | | | Date | Wed, 18 Apr 2012 06:55:40 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH v2 1/8] ohci-nxp: Driver cleanup |
| |
* Roland Stigge wrote: > --- linux-2.6.orig/drivers/usb/host/ohci-nxp.c > +++ linux-2.6/drivers/usb/host/ohci-nxp.c [...] > @@ -220,7 +220,7 @@ static void isp1301_configure_lpc32xx(vo > ISP1301_I2C_INTERRUPT_RISING | ISP1301_I2C_REG_CLEAR_ADDR, ~0); > > /* Enable usb_need_clk clock after transceiver is initialized */ > - __raw_writel((__raw_readl(USB_CTRL) | (1 << 22)), USB_CTRL); > + __raw_writel((__raw_readl(USB_CTRL) | USB_HOST_NEED_CLK_EN), USB_CTRL);
There's a pair of gratuitous parentheses here. Since you're changing the line anyway you can just drop them as well.
Thierry [unhandled content-type:application/pgp-signature] | |