lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] mmc: cd-gpio.c: Include header to pickup exported symbol prototypes
    On Tue, Apr 17, 2012 at 6:54 AM, H Hartley Sweeten
    <hartleys@visionengravers.com> wrote:
    > Include the linux/mmc/cd-gpio.h header to pickup the prototypes
    > for the two exported symbols.
    >
    > This quiets the sparse warnings:
    >
    > warning: symbol 'mmc_cd_gpio_request' was not declared. Should it be static?
    > warning: symbol 'mmc_cd_gpio_free' was not declared. Should it be static?
    >
    > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
    > Cc: Chris Ball <cjb@laptop.org>
    > Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
    >
    I posted a similar patch on friday. But yours has a more verbose commit log.
    Acked-by: Venkatraman S <svenkatr@ti.com>

    > ---
    >
    > diff --git a/drivers/mmc/core/cd-gpio.c b/drivers/mmc/core/cd-gpio.c
    > index 29de31e..da7c3f9 100644
    > --- a/drivers/mmc/core/cd-gpio.c
    > +++ b/drivers/mmc/core/cd-gpio.c
    > @@ -13,6 +13,7 @@
    >  #include <linux/interrupt.h>
    >  #include <linux/jiffies.h>
    >  #include <linux/mmc/host.h>
    > +#include <linux/mmc/cd-gpio.h>
    >  #include <linux/module.h>
    >  #include <linux/slab.h>
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at  http://vger.kernel.org/majordomo-info.html
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2012-04-17 10:21    [W:0.022 / U:30.252 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site