lkml.org 
[lkml]   [2012]   [Apr]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH RFC V5 3/6] kvm : Add unhalt msr to aid (live) migration
    On 04/12/2012 05:45 AM, Marcelo Tosatti wrote:
    > On Fri, Mar 23, 2012 at 01:37:26PM +0530, Raghavendra K T wrote:
    >> From: Raghavendra K T<raghavendra.kt@linux.vnet.ibm.com>
    >>

    [...]
    >
    > Unless there is a reason to use an MSR, should use a normal ioctl
    > such as KVM_{GET,SET}_MP_STATE.
    >
    >

    I agree with you. In the current implementation, since we are not doing
    any communication between host/guest (on this flag), I too felt MSR is
    an overkill for this.

    IMO, patch like below should do the job, which I am planning to include
    in next version of patch.
    Let me know if you foresee any side-effects.

    ---
    diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
    index aa44292..5c81a66 100644
    --- a/arch/x86/kvm/x86.c
    +++ b/arch/x86/kvm/x86.c
    @@ -5691,7 +5691,9 @@ int kvm_arch_vcpu_ioctl_get_sregs(struct kvm_vcpu
    *vcpu,
    int kvm_arch_vcpu_ioctl_get_mpstate(struct kvm_vcpu *vcpu,
    struct kvm_mp_state *mp_state)
    {
    - mp_state->mp_state = vcpu->arch.mp_state;
    + mp_state->mp_state = (vcpu->arch.mp_state == KVM_MP_STATE_HALTED &&
    + vcpu->pv_unhalted)?
    + KVM_MP_STATE_RUNNABLE : vcpu->arch.mp_state;
    return 0;
    }


    \
     
     \ /
      Last update: 2012-04-17 09:19    [W:0.021 / U:60.612 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site