Messages in this thread | | | Date | Tue, 17 Apr 2012 14:30:06 +0200 | From | Sascha Hauer <> | Subject | Re: [PATCH 1/3] pinctrl: pinctrl-imx: add imx pinctrl core driver |
| |
On Tue, Apr 17, 2012 at 05:57:23PM +0800, Dong Aisheng wrote: > Sascha & Shawn, > > Just let you know: > After changes the pinctrl table may look like: > (i also removed fsl,* config properties since it was introduced for better > readability before, but after dtc macro support is available, it could also > be removed. So i removed now. Then the using is much similar as iomux-v3). > > iomuxc@020e0000 { > compatible = "fsl,imx6q-iomuxc"; > reg = <0x020e0000 0x4000>; > > /* shared pinctrl settings */ > uart4 { > pinctrl_uart4_1: uart4grp-1 { > fsl,pins = <58 61>; > fsl,configs = <0x12407>
Why do we have a hex value for the config now? This should be independent on how we describe the mux settings.
Also I think a single fsl,configs entry for a pin group is not enough, what for example with I2C where the data line needs a pullup whereas the clock line does not?
Sascha
-- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |