lkml.org 
[lkml]   [2012]   [Apr]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: mtip32xx: Add new bitwise flag 'dd_flag'
On 4/16/2012 4:12 AM, Dan Carpenter wrote:

> Hello Asai Thambi S P,
>
> The patch 45038367c271: "mtip32xx: Add new bitwise flag 'dd_flag'"
> from Apr 9, 2012, leads to the following Smatch warning:
> drivers/block/mtip32xx/mtip32xx.c:2516 mtip_hw_get_scatterlist()
> warn: inconsistent returns sem:&dd->port->cmd_slot: locked (2514,2516) unlocked ()
>
> @@ -2193,6 +2245,10 @@ static struct scatterlist *mtip_hw_get_scatterlist(struct driver_data *dd,
> down(&dd->port->cmd_slot);
> *tag = get_slot(dd->port);
>
> + if (unlikely(test_bit(MTIP_DD_FLAG_REMOVE_PENDING_BIT, &dd->dd_flag))) {
> + up(&dd->port->cmd_slot);
> ^^^^^^^^^^^^^^^^^^^^^^^
> We release the lock here.
>
> + return NULL;
> + }
> if (unlikely(*tag < 0))
> return NULL;
> ^^^^^^^^^^^^
> Should we release it here as well?
>

Thanks for finding this. I should start using smatch :). I will send out the
patch.

--
Regards,
Asai Thambi



\
 
 \ /
  Last update: 2012-04-16 21:25    [W:0.035 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site