Messages in this thread | | | From | "Heasley, Seth" <> | Subject | RE: [PATCH 1/1] lpc_sch: Add Intel Centerton Multifunction Device support | Date | Mon, 16 Apr 2012 16:42:41 +0000 |
| |
Hi Samuel,
>> >> +#define PCI_DEVICE_ID_INTEL_CENTERTON_ILB 0x0c60 >> + >So we're not going to need this ID anywhere else ? In the GPIO driver >for example ? >If we do need it there, this ID should move to pci_ids.h
Actually, it looks like the GPIO driver *will* need it, so I'll go ahead and move it to pci_ids.h since it's used in more than one driver.
>> static struct resource smbus_sch_resource = { >> .flags = IORESOURCE_IO, >> }; >> @@ -68,7 +71,7 @@ static struct resource wdt_sch_resource = { >> >> static struct mfd_cell tunnelcreek_cells[] = { >> { >> - .name = "tunnelcreek_wdt", >> + .name = "ie6xx_wdt", >What do we need this change for ?
As mentioned in a previous email, the wdt driver is being renamed, so I'm reflecting that here.
I'll make a couple of changes and resubmit.
Regards, -Seth
| |